Change in coreboot[master]: mb/google/volteer/variants/eldrid: add spd for H5ANAG6NCJR-XNC
Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: add spd for H5ANAG6NCJR-XNC ......................................................................
mb/google/volteer/variants/eldrid: add spd for H5ANAG6NCJR-XNC
Add spd support for DDR4 memory part H5ANAG6NCJR-XNC.
Eldrid should use DRAM_ID strap ID 4 (0100) on SKUs populated with H5ANAG6NCJR-XNC DDR4 memory parts.
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds successfully.
Change-Id: Ia26315479ce1a749a0f7c9e81f134f7068d7eb0b Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc M src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/45963/1
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc index cfc038e..b966612 100644 --- a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc @@ -6,3 +6,4 @@ SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE, MT40A1G16KD-062E:E +SPD_SOURCES += ddr4-spd-9.hex # ID = 4(0b0100) Parts = H5ANAG6NCJR-XNC diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt index 867eca8..3e298dc 100644 --- a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt @@ -5,3 +5,4 @@ K4A8G165WC-BCWE 0 (0000) K4AAG165WA-BCWE 3 (0011) MT40A1G16KD-062E:E 3 (0011) +H5ANAG6NCJR-XNC 4 (0100) diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt index 36e0f68..dbe7ecb 100644 --- a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt +++ b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt @@ -4,3 +4,4 @@ K4A8G165WC-BCWE K4AAG165WA-BCWE MT40A1G16KD-062E:E +H5ANAG6NCJR-XNC
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: add spd for H5ANAG6NCJR-XNC ......................................................................
Patch Set 1: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: add spd for H5ANAG6NCJR-XNC ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45963/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45963/1//COMMIT_MSG@7 PS1, Line 7: add spd Add SPD
https://review.coreboot.org/c/coreboot/+/45963/1//COMMIT_MSG@9 PS1, Line 9: spd SPD
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: add spd for H5ANAG6NCJR-XNC ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Angel Pons, Tim Wawrzynczak, Nick Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45963
to look at the new patch set (#2).
Change subject: mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC ......................................................................
mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC
Add SPD support for DDR4 memory part H5ANAG6NCJR-XNC.
Eldrid should use DRAM_ID strap ID 4 (0100) on SKUs populated with H5ANAG6NCJR-XNC DDR4 memory parts.
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds successfully.
Change-Id: Ia26315479ce1a749a0f7c9e81f134f7068d7eb0b Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc M src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/45963/2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45963/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45963/1//COMMIT_MSG@7 PS1, Line 7: add spd
Add SPD
Done.
https://review.coreboot.org/c/coreboot/+/45963/1//COMMIT_MSG@9 PS1, Line 9: spd
SPD
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45963 )
Change subject: mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC ......................................................................
mb/google/volteer/variants/eldrid: Add SPD for H5ANAG6NCJR-XNC
Add SPD support for DDR4 memory part H5ANAG6NCJR-XNC.
Eldrid should use DRAM_ID strap ID 4 (0100) on SKUs populated with H5ANAG6NCJR-XNC DDR4 memory parts.
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds successfully.
Change-Id: Ia26315479ce1a749a0f7c9e81f134f7068d7eb0b Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45963 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc M src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc index cfc038e..b966612 100644 --- a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc @@ -6,3 +6,4 @@ SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE, MT40A1G16KD-062E:E +SPD_SOURCES += ddr4-spd-9.hex # ID = 4(0b0100) Parts = H5ANAG6NCJR-XNC diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt index 867eca8..3e298dc 100644 --- a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt @@ -5,3 +5,4 @@ K4A8G165WC-BCWE 0 (0000) K4AAG165WA-BCWE 3 (0011) MT40A1G16KD-062E:E 3 (0011) +H5ANAG6NCJR-XNC 4 (0100) diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt index 36e0f68..dbe7ecb 100644 --- a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt +++ b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt @@ -4,3 +4,4 @@ K4A8G165WC-BCWE K4AAG165WA-BCWE MT40A1G16KD-062E:E +H5ANAG6NCJR-XNC
-
Angel Pons (Code Review) -
Caveh Jalali (Code Review)
-
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)