Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant ......................................................................
Patch Set 9:
(2 comments)
Patch Set 8:
(2 comments)
Patch Set 8:
(4 comments)
Do you want to add a data.vbt file ?
How? Can it be dumped someway? Currently using that for T430s seems working.
You can use intelvbttool to extract it from VGA Option Rom.
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t431s/romstage.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 37: pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x0c06a1);
They are different in the last line of this function.
There's no COM1 or COM2, so setting IO_DEC is a bit pointless. IMHO this should always be done in chipset code.
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 37: pci No need to write it here, only if you want to access io range 0x6a0 in romstage.
-
Patrick Rudolph (Code Review)