Change in coreboot[master]: mb/google/guybrush: Disable EN_SPKR on init - coreboot-gerrit

29 Mar 2022


      Attention is currently required from: Paul Menzel.
Yu-hsuan Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63145 )
Change subject: mb/google/guybrush: Disable EN_SPKR on init
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63145/comment/271f8b32_9589ab29 
PS1, Line 10: using GPIO AMP codec in depthcharge.
...
Why can’t it be enabled? Does it cause noise?
It's for saving some power. You can refer to b/195748546 for the details. Thanks.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic949cc95556913a2afef4a683a49eaa1e07e6147
Gerrit-Change-Number: 63145
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-hsuan Hsu yuhsuan@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 29 Mar 2022 01:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment