Attention is currently required from: Lance Zhao, Kapil Porwal, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70022 )
Change subject: acpi: Create a common method to add DmaProperty ......................................................................
Patch Set 2:
(2 comments)
File src/acpi/device.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164581): https://review.coreboot.org/c/coreboot/+/70022/comment/91481009_ce8ace59 PS2, Line 1194: if (prev_dsd == NULL) dsd = acpi_dp_new_table("_DSD"); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164581): https://review.coreboot.org/c/coreboot/+/70022/comment/e60b13de_3e58bc95 PS2, Line 1198: if (prev_dsd == NULL) acpi_dp_write(dsd); trailing statements should be on next line