Attention is currently required from: Tarun Tuli, Eran Mitrani.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69392 )
Change subject: mb/google/brya: add missing devices to DSDT ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69392/comment/3de1a667_67bd0b7a PS4, Line 10: SHA commit d22500f0c61f8c8e10d8f4a24e3e2bf031163c07
File src/mainboard/google/brya/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/69392/comment/331a1c32_1580abd5 PS4, Line 32: Device (FSPI) {}
Would it make sense to move these into their respective device . […]
Those looks like the Intel device APCI. And should include when enable the device in device tree. Better let Intel check the soc level code.
-
Eric Lai (Code Review)