Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28073 )
Change subject: mainboard/google/nocturne: turn off cams in D3 ......................................................................
Patch Set 1:
Can't find some proper documentation described that more clearly. Other than ACPI spec itself, https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/device-pow... may also have some high level descriptions.
Okay, so go back to the real problem itself. Without _PR3, nocturne can still enter s0ix state properly with same level of power consumption? On my side, all the reference platform with MIPI camera support all have _PR3 there, in early stage people still use _PS0 and _PS3 to put the code directly, but later all switch to _PR0 and _PR3 with _ON and _OFF inside power resources. For the privacy LED always on issue, what about move some the turn off programming to _STA that will be loaded as first input of driver? Or maybe move the programing to pre-OS stage to coreboot? Using windbg to log ACPI event through AMLI debugger may be easier to understand the sequence I believe.
-
Lijian Zhao (Code Review)