Change in coreboot[master]: soc/intel/cannonlake: Merge soc_memory_init_params() into its caller - coreboot-gerrit

23 Apr 2021


      Attention is currently required from: Michael Niewöhner, Patrick Rudolph.
 Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52491 )
Change subject: soc/intel/cannonlake: Merge soc_memory_init_params() into its caller
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
...
lol. […]
I don't think it makes much sense to split this up into more functions, since we are just configuring FSP options here and the functions would be used only once. I would rather use comments to clarify what is done.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52491
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3b6395ea5d5cb714a412c856d66d4a9bcbd9c12
Gerrit-Change-Number: 52491
Gerrit-PatchSet: 7
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 23 Apr 2021 09:49:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment