Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45145 )
Change subject: lib/Kconfig: Drop obsolete help text from GENERIC_SPD_BIN
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45145/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45145/1//COMMIT_MSG@7
PS1, Line 7: GENERIC_SPD_BIN: drop historic part of help text
I'd use `obsolete` instead of `historic`. To avoid having two levels of colons, I'd use: […]
Done
https://review.coreboot.org/c/coreboot/+/45145/1//COMMIT_MSG@9
PS1, Line 9: 0e3c59e
To allow Gerrit (and possibly other programs) to consider this as a short commit hash, prepend it wi […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I603ab012760684021be1b5eca5d0ddff69463b79
Gerrit-Change-Number: 45145
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Sep 2020 19:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment