Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Arthur Heymans, Lean Sheng Tan, Werner Zeh, Sukumar Ghorai, Raj Astekar.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70751 )
Change subject: soc/intel/common: Fix cpu index calculation
......................................................................
Patch Set 5:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70751/comment/08fc9b7d_de7cd42a
PS4, Line 10: Ids
Please, spell ID consistent across this commit message (I would prefer all upper case but have no st […]
Ack
https://review.coreboot.org/c/coreboot/+/70751/comment/f9174eb2_abba0855
PS4, Line 22: results incorrect
Maybe "results in wrong"?
Ack
https://review.coreboot.org/c/coreboot/+/70751/comment/0cecad5b_bd368dac
PS4, Line 24: the
extra "the"
Ack
https://review.coreboot.org/c/coreboot/+/70751/comment/576e961c_9e82eb0f
PS4, Line 27: the
that the
Ack
https://review.coreboot.org/c/coreboot/+/70751/comment/938a2b09_a39fad67
PS4, Line 28: CPU
Please spell CPU consistent in this commit message (again, I would prefer upper case but up to you).
Ack
https://review.coreboot.org/c/coreboot/+/70751/comment/a824ff43_d8b59f0b
PS4, Line 30: fix
Maybe "this patch"?
Ack
https://review.coreboot.org/c/coreboot/+/70751/comment/e601ce8c_27680d28
PS4, Line 57: After fix..
After this patch:
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69e5e6231dd18b43d439340aaed50eb9edeca3b7
Gerrit-Change-Number: 70751
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 14:29:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment