[S] Change in coreboot[master]: sb,soc/intel: Drop spurious SMI entry message

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Jeff Daly, Vanessa Eusebio.

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70047 )

Change subject: sb,soc/intel: Drop spurious SMI entry message
......................................................................

sb,soc/intel: Drop spurious SMI entry message

The message only makes sense if ACPI PM base address is
allowed to be dynamic. If requested, it can be logged
in common code.

Change-Id: Iad7a60098c0391cc23384035af49e373dad90233
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/baytrail/smm.c
M src/soc/intel/braswell/smm.c
M src/soc/intel/broadwell/pch/smi.c
M src/soc/intel/denverton_ns/smm.c
M src/southbridge/intel/common/smi.c
M src/southbridge/intel/lynxpoint/smi.c
6 files changed, 15 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/70047/1

diff --git a/src/soc/intel/baytrail/smm.c b/src/soc/intel/baytrail/smm.c
index 3f3c53f..ed83173 100644
--- a/src/soc/intel/baytrail/smm.c
+++ b/src/soc/intel/baytrail/smm.c
@@ -27,8 +27,6 @@
    if (CONFIG(ELOG))
    	southcluster_log_state();

-	printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
-	printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());

smi_en = inl(get_pmbase() + SMI_EN);
    if (smi_en & APMC_EN) {
diff --git a/src/soc/intel/braswell/smm.c b/src/soc/intel/braswell/smm.c
index 3f3c53f..64e560e 100644
--- a/src/soc/intel/braswell/smm.c
+++ b/src/soc/intel/braswell/smm.c
@@ -27,9 +27,6 @@
    if (CONFIG(ELOG))
    	southcluster_log_state();

-	printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
-	printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());
-
    smi_en = inl(get_pmbase() + SMI_EN);
    if (smi_en & APMC_EN) {
    	printk(BIOS_INFO, "SMI# handler already enabled?\n");
diff --git a/src/soc/intel/broadwell/pch/smi.c b/src/soc/intel/broadwell/pch/smi.c
index d7704fd..51f31a1 100644
--- a/src/soc/intel/broadwell/pch/smi.c
+++ b/src/soc/intel/broadwell/pch/smi.c
@@ -14,17 +14,12 @@
 {
    u32 smi_en;

-	printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
-	printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", ACPI_BASE_ADDRESS);
-
    smi_en = inl(ACPI_BASE_ADDRESS + SMI_EN);
    if (smi_en & APMC_EN) {
    	printk(BIOS_INFO, "SMI# handler already enabled?\n");
    	return;
    }

-	printk(BIOS_DEBUG, "\n");
-
    /* Dump and clear status registers */
    clear_smi_status();
    clear_pm1_status();
diff --git a/src/soc/intel/denverton_ns/smm.c b/src/soc/intel/denverton_ns/smm.c
index e7ed28d..bb399e8 100644
--- a/src/soc/intel/denverton_ns/smm.c
+++ b/src/soc/intel/denverton_ns/smm.c
@@ -16,9 +16,6 @@
 {
    uint32_t smi_en;

-	printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
-	printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());
-
    smi_en = inl((uint16_t)(get_pmbase() + SMI_EN));
    if (smi_en & APMC_EN) {
    	printk(BIOS_INFO, "SMI# handler already enabled?\n");
diff --git a/src/southbridge/intel/common/smi.c b/src/southbridge/intel/common/smi.c
index 20926e5..a6e000b 100644
--- a/src/southbridge/intel/common/smi.c
+++ b/src/southbridge/intel/common/smi.c
@@ -23,15 +23,12 @@
    if (CONFIG(ELOG))
    	pch_log_state();

-	printk(BIOS_DEBUG, "Initializing southbridge SMI...");
-	printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", lpc_get_pmbase());
-
    smi_en = read_pmbase32(SMI_EN);
    if (smi_en & APMC_EN) {
    	printk(BIOS_INFO, "SMI# handler already enabled?\n");
    	return 1;
    }
-	printk(BIOS_DEBUG, "\n");
+
    return 0;
 }

diff --git a/src/southbridge/intel/lynxpoint/smi.c b/src/southbridge/intel/lynxpoint/smi.c
index 70d9dc1..280235f 100644
--- a/src/southbridge/intel/lynxpoint/smi.c
+++ b/src/southbridge/intel/lynxpoint/smi.c
@@ -18,17 +18,12 @@
    if (CONFIG(ELOG))
    	pch_log_state();

-	printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
-	printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", get_pmbase());
-
    smi_en = inl(get_pmbase() + SMI_EN);
    if (smi_en & APMC_EN) {
    	printk(BIOS_INFO, "SMI# handler already enabled?\n");
    	return;
    }

-	printk(BIOS_DEBUG, "\n");
-
    /* Dump and clear status registers */
    clear_smi_status();
    clear_pm1_status();