Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 )
Change subject: mb/clevo/l140cu: add panel settings to devicetree ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48750/1/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/1/src/mainboard/clevo/cml-u/v... PS1, Line 69: register "SkipExtGfxScan" = " 1" : register "gpu_pp_up_delay_ms" = " 200" : register "gpu_pp_down_delay_ms" = " 50" : register "gpu_pp_cycle_delay_ms" = " 500" : register "gpu_pp_backlight_on_delay_ms" = " 1" : register "gpu_pp_backlight_off_delay_ms" = " 200" : register "gpu_pch_backlight_pwm_hz" = "1000"
just copy-pasta for now; need to check the values
The values were updated, it seems?
https://review.coreboot.org/c/coreboot/+/48750/2/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/2/src/mainboard/clevo/cml-u/v... PS2, Line 76: register "SkipExtGfxScan" = "1" How is this related?
-
Nico Huber (Code Review)