HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33690
Change subject: soc/mediatek: Use 'include <stdlib.h>' when appropriate ......................................................................
soc/mediatek: Use 'include <stdlib.h>' when appropriate
Change-Id: Id6d881055826044d04843ba165641131b9111342 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/mediatek/common/spi.c M src/soc/mediatek/mt8173/flash_controller.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/33690/1
diff --git a/src/soc/mediatek/common/spi.c b/src/soc/mediatek/common/spi.c index 1af6f10..21ece21 100644 --- a/src/soc/mediatek/common/spi.c +++ b/src/soc/mediatek/common/spi.c @@ -17,9 +17,9 @@ #include <assert.h> #include <console/console.h> #include <endian.h> -#include <stdlib.h> #include <soc/pll.h> #include <soc/spi.h> +#include <stddef.h> #include <timer.h>
#define MTK_SPI_DEBUG 0 diff --git a/src/soc/mediatek/mt8173/flash_controller.c b/src/soc/mediatek/mt8173/flash_controller.c index bca2ecf..305aca6 100644 --- a/src/soc/mediatek/mt8173/flash_controller.c +++ b/src/soc/mediatek/mt8173/flash_controller.c @@ -21,12 +21,12 @@ #include <spi_flash.h> #include <spi-generic.h> #include <stdint.h> -#include <stdlib.h> #include <string.h> #include <symbols.h> #include <timer.h> #include <soc/symbols.h> #include <soc/flash_controller.h> +#include <stddef.h>
#define get_nth_byte(d, n) ((d >> (8 * n)) & 0xff)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33690
to look at the new patch set (#4).
Change subject: soc/mediatek: Use 'include <stdlib.h>' when appropriate ......................................................................
soc/mediatek: Use 'include <stdlib.h>' when appropriate
Also including <types.h>, is supposed to provide stdint and stddef.
Change-Id: Id6d881055826044d04843ba165641131b9111342 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/mediatek/common/spi.c M src/soc/mediatek/mt8173/flash_controller.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/33690/4
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33690 )
Change subject: soc/mediatek: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33690 )
Change subject: soc/mediatek: Use 'include <stdlib.h>' when appropriate ......................................................................
soc/mediatek: Use 'include <stdlib.h>' when appropriate
Also including <types.h>, is supposed to provide stdint and stddef.
Change-Id: Id6d881055826044d04843ba165641131b9111342 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33690 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/mediatek/common/spi.c M src/soc/mediatek/mt8173/flash_controller.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/mediatek/common/spi.c b/src/soc/mediatek/common/spi.c index 1af6f10..40ab9b7 100644 --- a/src/soc/mediatek/common/spi.c +++ b/src/soc/mediatek/common/spi.c @@ -17,10 +17,10 @@ #include <assert.h> #include <console/console.h> #include <endian.h> -#include <stdlib.h> #include <soc/pll.h> #include <soc/spi.h> #include <timer.h> +#include <types.h>
#define MTK_SPI_DEBUG 0
diff --git a/src/soc/mediatek/mt8173/flash_controller.c b/src/soc/mediatek/mt8173/flash_controller.c index bca2ecf..b491a41 100644 --- a/src/soc/mediatek/mt8173/flash_controller.c +++ b/src/soc/mediatek/mt8173/flash_controller.c @@ -21,12 +21,12 @@ #include <spi_flash.h> #include <spi-generic.h> #include <stdint.h> -#include <stdlib.h> #include <string.h> #include <symbols.h> #include <timer.h> #include <soc/symbols.h> #include <soc/flash_controller.h> +#include <types.h>
#define get_nth_byte(d, n) ((d >> (8 * n)) & 0xff)
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)