26 Mar
2019
26 Mar
'19
5:21 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29957 )
Change subject: libpayload: Add UART for qcs405 ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/#/c/29957/17/payloads/libpayload/drivers/serial/... File payloads/libpayload/drivers/serial/qcs405.c:
https://review.coreboot.org/#/c/29957/17/payloads/libpayload/drivers/serial/... PS17, Line 283: unsigned blsp_uart; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29957/17/payloads/libpayload/drivers/serial/... PS17, Line 399: void serial_putchar(unsigned data) Prefer 'unsigned int' to bare use of 'unsigned'
--
To view, visit https://review.coreboot.org/c/coreboot/+/29957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43164cf9eacc844af1d048f7b6ebbda96fc9d202
Gerrit-Change-Number: 29957
Gerrit-PatchSet: 17
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-Comment-Date: Tue, 26 Mar 2019 15:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
2163
days inactive
2163
days old
0 comments
1 participants
participants (1)
-
build bot (Jenkins) (Code Review)