Attention is currently required from: Felix Singer, Jason Nien, Jeremy Soller, Michael Niewöhner, Martin Roth, Tim Crawford, Tarun Tuli, Martin L Roth, Damien Zammit, Subrata Banik, Maxim Polyakov, Kapil Porwal, Alexander Couzens, Werner Zeh, Evgeny Zinoviev.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68982 )
Change subject: mainboard: Add SPDX license headers to Makefiles
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I don't understand these questions. I don't know if anyone other than AMD is running license scans, but I am writing the patches, and Matt signed off on them. We're both AMD employees.
Oh, I'm very sorry. I have heard of demands from other companies before (or
at least I think I did) and didn't know AMD is directly involved.
You can generally prevent confusing questions by stating your reasons in the
commit message. e.g. why change? why GPL? is there a rule (missing)?
Now that I read "license scans" what would interest me most: Is this only
done because a tool told us to or is there a human advice behind it?
As far as the license used, the license of coreboot as a whole is GPL V2. If someone contributes a file and doesn't specify a different license, the license defaults to GPL V2 as a part of the coreboot project. These patches just clarify that the Makefile are licensed under GPL V2.
Is this documented somewhere? As the top-level Makefile is BSD licensed, I
would have guessed otherwise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic451e68b1ad9ccdf34484dd98bd7fca7e177ef22
Gerrit-Change-Number: 68982
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Sun, 20 Nov 2022 10:13:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment