Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77444?usp=email )
Change subject: mb/dell: Add Latitude E6430 (Ivy Bridge) ......................................................................
Patch Set 11:
(4 comments)
File src/mainboard/dell/snb_ivb_latitude/devicetree.cb:
PS10:
Missing license header
Done
File src/mainboard/dell/snb_ivb_latitude/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/77444/comment/5b97f8be_5f4c4f39 : PS10, Line 3: /* SPDX-License-Identifier: GPL-2.0-only */
Move license header before the others
Done. It's probably a quirk in autoport where the license header function gets called to late (side note, I think the way autoport is structured with all text inline with the code makes it more difficult to make updates to the output format when things change). It seems like those defines are only really relevant to the the ThinkPads, so I just removed them.
File src/mainboard/dell/snb_ivb_latitude/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/77444/comment/b7415cc9_f095b271 : PS10, Line 14: DP2, -- dock DP : DP3, -- dock DP
Add HDMI for dock DVI ports
Done
File src/mainboard/dell/snb_ivb_latitude/variants/e6430/overridetree.cb:
PS10:
Missing license header
Done. It should also be fixed in the rest of the ports now.
-
Nicholas Chin (Code Review)