[M] Change in coreboot[master]: mb/google/myst: Enable AP <-> GSC communication - coreboot-gerrit

3 Apr 2023


      Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74111 )
Change subject: mb/google/myst: Enable AP <-> GSC communication
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74111/comment/0fef4ea1_315ded3c 
PS8, Line 178: 	PAD_NF(GPIO_113, I2C2_SCL, PULL_NONE),
...
I was looking at the schematic: […]
go/myst-gpios does list GPIO 113 and 114, they're just muxed.  Look at cumulative GPIO 60 and 61
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e235356b252a7b68a42da128ffd3189a829f117
Gerrit-Change-Number: 74111
Gerrit-PatchSet: 8
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 18:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Comment-In-Reply-To: Mark Hasemeyer markhas@google.com
Gerrit-MessageType: comment