Change in coreboot[master]: drivers/ipmi: add code to set BMC/IPMI enablement from jumper
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48094 )
Change subject: drivers/ipmi: add code to set BMC/IPMI enablement from jumper ......................................................................
Patch Set 43: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48094/43/src/drivers/ipmi/chip.h File src/drivers/ipmi/chip.h:
https://review.coreboot.org/c/coreboot/+/48094/43/src/drivers/ipmi/chip.h@24 PS43, Line 24: u16 should this be `gpio_t` from `<soc/gpio.h>` ?
https://review.coreboot.org/c/coreboot/+/48094/43/src/drivers/ipmi/ipmi_kcs_... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/48094/43/src/drivers/ipmi/ipmi_kcs_... PS43, Line 94: specified this word seems extraneous
-
Tim Wawrzynczak (Code Review)