Attention is currently required from: Nico Huber, Furquan Shaikh, Matt DeVillier, Jeremy Soller, Angel Pons, Michael Niewöhner, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56008 )
Change subject: cannonlake mainboards: Set PMC as hidden in devicetree
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56008/comment/53adfa3c_8e68cd94
PS2, Line 14:
Were any tests done?
Planning to verify this on google/dratini soon.
Patchset:
PS2:
"hidden" is not meant to be used with devices but with bridges, where the devices behind that bridge […]
Not true, I wrote the code that switched the meaning of hidden (it was unused at the time in any devicetree, see https://doc.coreboot.org/releases/coreboot-4.13-relnotes.html?highlight=hidd...). This is what TGL, JSL, EKL, and ADL do with their PMC devices, it allows you to use device callbacks on it even though the device is not discoverable during PCI enumeration. CB:41384
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56008
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a20ce9075ce7653388a5d3e281fe774bf89355
Gerrit-Change-Number: 56008
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 02 Jul 2021 15:38:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment