Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73322 )
Change subject: mb/amd/gardenia,pademelon/mainboard: use ACPI_SCI_IRQ definition ......................................................................
mb/amd/gardenia,pademelon/mainboard: use ACPI_SCI_IRQ definition
Use the ACPI_SCI_IRQ definition for both the PIC and APIC IRQ number in the fch_irq_map table. Before the PIC mapping was set to PIRQ_NC, but both mb/google/kahlee and the other amd mainboards using newer SoCs set both the PIC and APCI IRQ number to ACPI_SCI_IRQ, so change this here to match the other mainboards.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I29dde7ca8d2ecf00d8174c2d793ef1ad55ae3e28 --- M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/pademelon/mainboard.c 2 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/73322/1
diff --git a/src/mainboard/amd/gardenia/mainboard.c b/src/mainboard/amd/gardenia/mainboard.c index 39f1697..d89449f 100644 --- a/src/mainboard/amd/gardenia/mainboard.c +++ b/src/mainboard/amd/gardenia/mainboard.c @@ -4,6 +4,7 @@ #include <amdblocks/agesawrapper.h> #include <amdblocks/amd_pci_util.h> #include <gpio.h> +#include <soc/acpi.h> #include <soc/southbridge.h>
#include "gpio.h" @@ -19,7 +20,7 @@ { PIRQ_F, 10, 21 }, { PIRQ_G, PIRQ_NC, 22 }, { PIRQ_H, PIRQ_NC, 23 }, - { PIRQ_SCI, PIRQ_NC, 9 }, + { PIRQ_SCI, ACPI_SCI_IRQ, ACPI_SCI_IRQ }, { PIRQ_SMBUS, PIRQ_NC, PIRQ_NC }, { PIRQ_HDA, 3, 16 }, { PIRQ_SD, PIRQ_NC, 16 }, diff --git a/src/mainboard/amd/pademelon/mainboard.c b/src/mainboard/amd/pademelon/mainboard.c index d10de26..8be12f1 100644 --- a/src/mainboard/amd/pademelon/mainboard.c +++ b/src/mainboard/amd/pademelon/mainboard.c @@ -4,6 +4,7 @@ #include <amdblocks/agesawrapper.h> #include <amdblocks/amd_pci_util.h> #include <gpio.h> +#include <soc/acpi.h> #include <soc/pci_devs.h> #include <soc/southbridge.h>
@@ -20,7 +21,7 @@ { PIRQ_F, 10, 21 }, { PIRQ_G, PIRQ_NC, 22 }, { PIRQ_H, PIRQ_NC, 23 }, - { PIRQ_SCI, PIRQ_NC, 9 }, + { PIRQ_SCI, ACPI_SCI_IRQ, ACPI_SCI_IRQ }, { PIRQ_SMBUS, PIRQ_NC, PIRQ_NC }, { PIRQ_HDA, 3, 16 }, { PIRQ_SD, PIRQ_NC, 16 },