Julius Werner has posted comments on this change. ( https://review.coreboot.org/19558 )
Change subject: google/gru: support 800M/928M frequency for bob ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/19558/3/src/mainboard/google/gru/sdram_confi... File src/mainboard/google/gru/sdram_configs.c:
Line 49: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4)
Then, can the CONFIG_GRU_SDRAM_FREQ be defined by the board_id()?
Oh, yeah, right. I forgot why we've been doing this whole thing. Sorry.
https://review.coreboot.org/#/c/19558/4/src/mainboard/google/gru/sdram_confi... File src/mainboard/google/gru/sdram_configs.c:
Line 49: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4) Okay, you were right about the Kconfig, of course (although it might still be nice to have a user-configurable Kconfig and then just do max(CONFIG_GRU_SDRAM_FREQ, 800) for the older Bob boards). But I'd still like to do this with a single table and an snprintf() instead. Just write an int get_sdram_freq(void) function and put the Bob board ID stuff in there.
https://review.coreboot.org/#/c/19558/4/src/mainboard/google/gru/sdram_param... File src/mainboard/google/gru/sdram_params_800/Makefile.inc:
Line 16: freq := 800 And the stuff I said about file names here still applies, too.