Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, Lance Zhao, Martin L Roth, Maximilian Brune, Nico Huber, Patrick Rudolph, Tim Wawrzynczak.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78071?usp=email )
Change subject: acpi: Add PPTT support ......................................................................
Patch Set 22:
(3 comments)
File src/acpi/acpi_pptt.c:
https://review.coreboot.org/c/coreboot/+/78071/comment/23a9c341_872ce435 : PS17, Line 131: cache_reference_t cache_refs[CONFIG_ACPI_PPTT_MAX_CACHES];
Well, QEMU-SBSA is a rather simple example, with a homogenuous hierarchy
and caches known at compile time. I just wonder how it will look like for a more complex setup when one has to allocate struct pptt_cache nodes at runtime. Then it would be harder to reuse the nodes and their pointers. But I guess we can handle that if/when the time comes.
Agreed.
I think we can close this discussion?
File src/acpi/acpi_pptt.c:
https://review.coreboot.org/c/coreboot/+/78071/comment/080ee310_c67e88ca : PS21, Line 148: cpu_node->resources[cpu_node->n_resources++] = new_pptt_cache(current, it->cache, cache_list);
In https://uefi. […]
Considered doing that. Not sure anymore why exactly, but I decided against it. I think the current solution is fine.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/78071/comment/fc4258af_99784003 : PS21, Line 1448: u32 size_valid : 1; : u32 n_sets_valid : 1; : u32 associativity_valid : 1; : u32 alloc_type_valid : 1; : u32 cache_type_valid : 1; : u32 write_policy_valid : 1; : u32 line_size_valid : 1; : u32 cache_id_valid : 1; : u32 reserved : 24;
Bitfields or not, unless the table is defined to be in host […]
Done
-
David Milosevic (Code Review)