Attention is currently required from: Angel Pons, Patrick Rudolph.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59523 )
Change subject: nb/intel/sandybridge/romstage.c: Configure DPR and initialize TXT
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/sandybridge/romstage.c:
https://review.coreboot.org/c/coreboot/+/59523/comment/b42507d8_bcff0dbd
PS2, Line 78: #if CONFIG(INTEL_TXT)
I'm afraid I don't follow. The only redundant MSR writing I see is the one CB:59521 adds. That MSR needs to be written even if TXT is not supported.
Okay, just yesterday I was still convinced it shouldn't be written if CPU or chipset is not TXT capable, due to #GP it may cause (according to TXT BIOS spec).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b912f121593fa55c11813262f09be1a1055e950
Gerrit-Change-Number: 59523
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Nov 2021 16:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment