Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74399 )
Change subject: cpu,soc/intel: Separate single SSDT CPU entry ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74399/comment/1d85d313_ef709727 PS1, Line 422: generate_cpu_entry(device, cpu_id, core_id, num_virt);
This loop order determines UUIDs for each CPU Device().
Now, as long as we create a symmetrical entry for each CPU, the order does not really matter. But the UUIDs need/should sync with MADT LAPIC entries?
Should the MADT order be kept inside path and generating SSDT be added to cpu ops of each lapic rather than as ops of the cpu cluster which loops over numbers?
Is it really okay that we use the BSP CPU to create also the AP CPU's entries on some platforms?
I guess it's fragile?
-
Arthur Heymans (Code Review)