Change in coreboot[master]: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEV...

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59260 )

Change subject: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEVICE_SLEEP_D3_COLD
......................................................................

mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEVICE_SLEEP_D3_COLD

Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips initial
probe during kernel boot and prevent privacy LED blink.

BUG=b:199823938
TEST=Build and boot redrix to OS. Verify entries in SSDT and monitor LED
during boot.

Signed-off-by: Varshit B Pandya 
Change-Id: I88ea1b87698c63e1bd69367ee857fba3f25c84ea
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59260
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/brya/variants/redrix/overridetree.cb
1 file changed, 14 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index dc1a424..e4119f6 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -276,6 +276,7 @@
    			register "num_freq_entries" = "1"
    			register "link_freq[0]" = "DEFAULT_LINK_FREQ"
    			register "remote_name" = ""IPU0""
+				register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD"

register "has_power_resource" = "1"
    			#Controls
@@ -311,6 +312,7 @@
    			register "acpi_name" = ""CAM0""
    			register "chip_name" = ""Hi-556 Camera""
    			register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
+				register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD"

register "ssdb.lanes_used" = "2"
    			register "ssdb.link_used" = "1"
@@ -351,8 +353,19 @@
    			register "acpi_name" = ""NVM0""
    			register "chip_name" = ""M24C64X""
    			register "device_type" = "INTEL_ACPI_CAMERA_NVM"
+				register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D0"

-				register "pr0" = ""\_SB.PCI0.I2C2.CAM0.PRIC""
+				register "has_power_resource" = "1"
+				#Controls
+				register "gpio_panel.gpio[0].gpio_num" = "GPP_D16" #EN_UCAM_PWR
+
+				#_ON
+				register "on_seq.ops_cnt" = "1"
+				register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 0)"
+
+				#_OFF
+				register "off_seq.ops_cnt" = "1"
+				register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"

register "nvm_size" = "0x2000"
    			register "nvm_pagesize" = "1"