Attention is currently required from: Arthur Heymans, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 )
Change subject: arch/arm: Fix assembling files with clang ......................................................................
Patch Set 26:
(4 comments)
Patchset:
PS26: All instructions should be the same now.
File src/arch/arm/libgcc/lib1funcs.S:
https://review.coreboot.org/c/coreboot/+/63058/comment/d923089e_d0730f36 PS1, Line 70: movne \curbit, \curbit, lsr #4 @ No, any more bits to do?
Are you trying to copy what 'ARM: 8844/1: use unified assembler in assembly files' did in Linux? T […]
Done
File src/arch/arm/memset.S:
https://review.coreboot.org/c/coreboot/+/63058/comment/b3c5aa42_c03956e8 PS1, Line 46:
Should still use tabs to align like the rest of the code.
Done
https://review.coreboot.org/c/coreboot/+/63058/comment/88f74106_5094192c PS1, Line 111: strle r1, [ip], #1 @ 1
This is changing the instruction too.
Done
-
Arthur Heymans (Code Review)