Change in ...coreboot[master]: nb/intel/pineview: Remove unused code

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33408

Change subject: nb/intel/pineview: Remove unused code
......................................................................

nb/intel/pineview: Remove unused code

All the clocks are switched on anyway, so this series of if statements
isn't needed.

Change-Id: I654043fd6736caa6890fd697015c577ddaa7cd41
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 13473{27-30}
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 1 insertion(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/33408/1

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 72063cb..1d24ea2 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -1141,16 +1141,7 @@

MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1;
    MCHBAR32(0x1a0) = 0x551803;
-	if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0)) {
-		reg8 = 0x3c;
-	} else if (ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) {
-		reg8 = 0x27;
-	} else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, 0)) {
-		reg8 = 0x24;
-	} else {
-		// None
-		reg8 = 0x3f;
-	}
+
    reg8 = 0x00; //switch all clocks on anyway

MCHBAR32(0x5a0) = (MCHBAR32(0x5a0) & ~0x3f000000) | (reg8 << 24);

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33408 )

Change subject: nb/intel/pineview: Remove unused code
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33408 )

Change subject: nb/intel/pineview: Remove unused code
......................................................................

Patch Set 1: Code-Review+2

lol

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33408 )

Change subject: nb/intel/pineview: Remove unused code
......................................................................

nb/intel/pineview: Remove unused code

All the clocks are switched on anyway, so this series of if statements
isn't needed.

Change-Id: I654043fd6736caa6890fd697015c577ddaa7cd41
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 13473{27-30}
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33408
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Angel Pons 
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 1 insertion(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 72063cb..1d24ea2 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -1141,16 +1141,7 @@

MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1;
    MCHBAR32(0x1a0) = 0x551803;
-	if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0)) {
-		reg8 = 0x3c;
-	} else if (ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) {
-		reg8 = 0x27;
-	} else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, 0)) {
-		reg8 = 0x24;
-	} else {
-		// None
-		reg8 = 0x3f;
-	}
+
    reg8 = 0x00; //switch all clocks on anyway

MCHBAR32(0x5a0) = (MCHBAR32(0x5a0) & ~0x3f000000) | (reg8 << 24);