Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56275 )
Change subject: soc/amd/picasso: implement and use mca_is_valid_bank
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/56275/comment/bbb7c42f_117d5a32
PS1, Line 142: ""
Does that mean this should be NULL instead?
all MSRs we want to access exist for this bank, so no need to do this. setting it to NULL is basically only to work around the problem on stoneyridge where we'd be getting general protection faults. so it's still a valid MCAX bank; it just won't do anything if i read the docs correctly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c7f3066afd220e6b8bf8308a321189d7a2679f6
Gerrit-Change-Number: 56275
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 21:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment