Change in coreboot[master]: soc/amd: Make espi_configure_decodes private - coreboot-gerrit

2 Apr 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52059 )
Change subject: soc/amd: Make espi_configure_decodes private
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/52059/comment/c453c581_6a8b9c35 
PS4, Line 71: espi_clear_decodes
Given that we are doing a complete reset of the eSPI controller in `espi_setup()` anyways, I think we should just move this to `espi_setup()` as well.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I074e487d8768a578ee889a125b9948e3aa6c7269
Gerrit-Change-Number: 52059
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Apr 2021 18:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment