Attention is currently required from: Hung-Te Lin, Jarried Lin.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )
Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................
Patch Set 12:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85362/comment/bbc59134_8c573be7?usp... :
PS12, Line 8:
The Booker's protocol is generally similar to CI-700, with some MTK modifications. […]
Yes, I found a Web site for CI-700. Still, you should add a paragraph about the device. Especially as no other MediaTek device in coreboot seems to have used it until now.
https://review.coreboot.org/c/coreboot/+/85362/comment/a71cafc4_5d03b115?usp... :
PS12, Line 20: [booker_init] AP hash rule: 0xbe00.
Hash rule is an algorithm that implements different hash functions for a device in MTK.
How can I decode the value?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85362?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6bde1e20137890addf18b23b47f17b1f63824b22
Gerrit-Change-Number: 85362
Gerrit-PatchSet: 12
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dehui Sun
dehui.sun@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 04 Dec 2024 14:21:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Dehui Sun
dehui.sun@mediatek.corp-partner.google.com