Attention is currently required from: Martin Roth, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Subrata Banik, Michal Motyl, Kyösti Mälkki, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49880 )
Change subject: [WIP] soc/intel: Remove duplicate call to acpi_wake_source()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
Tim, Subrata; can you check if this actually fixes something so we can get the commit message right.
With this patch series, on my TGL device:
```
localhost ~ # cbmem -1 | egrep -i 'pm1|gpe'
pm1_sts: 8100 pm1_en: 0100 pm1_cnt: 00001400
gpe0_sts[0]: 00209000 gpe0_en[0]: 00000000
gpe0_sts[1]: 0000000e gpe0_en[1]: 00000000
gpe0_sts[2]: 00000804 gpe0_en[2]: 00008000
gpe0_sts[3]: 00000040 gpe0_en[3]: 00012200
SMI_STS: PM1
PM1_STS: WAK PWRBTN
GPE0 STD STS: TCO_SCI
ACPI _SWS is PM1 Index 8 GPE Index -1
```
They actually both look correct here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74fdae63111e3ea09000d888a918ebe70d711801
Gerrit-Change-Number: 49880
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 27 Jan 2021 21:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment