Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51980 )
Change subject: mb/prodrive/hermes: Properly pack EEPROM structures
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h:
https://review.coreboot.org/c/coreboot/+/51980/comment/d48d6c10_0b4a0e96
PS3, Line 39: __packed
not sure if there is a rule about it, but isn't __packed usually written after the closing bracked? […]
No, there isn't a rule about it. Both placements work, but I prefer to put it at the start. vc/amd/fsp/ also does the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39d2c9ebc370605d5623b134189aa95a074ec7c3
Gerrit-Change-Number: 51980
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 03 Apr 2021 18:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment