Attention is currently required from: Andrey Petrov, Kapil Porwal, Ronak Kanabar, Subrata Banik, Tarun Tuli.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75919?usp=email )
Change subject: driver/{intel,mrc_cache}: Have MRC cache ver. based on FSP-M/MRC ver ......................................................................
Patch Set 3:
(1 comment)
File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/75919/comment/d8efa116_5f0e12ee : PS3, Line 14: help
This choice is user visible on ALL users of CACHE_MRC_SETTINGS, however not all users use FSP and the choice is not even meaningfull on all FSP platforms.
Is a user visible option even meaningful? The FSP either exposes extended header or it does not. The user should not have to figure this out. The platform should select the right option.
isn't the help msg is self explanatory ? i got your point but there is no need to give -1 for such reason (an unsolved comment itself is enough as in the latest patchset is not even +2'ed)
Yes but why should the user even have to read the help msg in the menu if it can be avoided. -1 gets removed on updating a patch iirc.