Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: src/mainboard/libretrend/lt1000: Initial commit
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Please also add to Documentation:
* Position of the flash IC
* Recommended flashing methods
* pin headers and jumpers for flashing
* TODOs
Is libgfxinit working?
https://review.coreboot.org/#/c/30360/6/src/mainboard/libretrend/lt1000/hda_...
File src/mainboard/libretrend/lt1000/hda_verb.c:
https://review.coreboot.org/#/c/30360/6/src/mainboard/libretrend/lt1000/hda_...
PS6, Line 26: static void codecs_init(u8 *base, u32 codec_mask)
please use src/soc/intel/common/block/hda/hda.c instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab
Gerrit-Change-Number: 30360
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 10 May 2019 09:36:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment