Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31841 )
Change subject: Documentation/soc/intel: Add MP Initialization document ......................................................................
Patch Set 4:
(14 comments)
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... File Documentation/soc/intel/mp_init/mp_init.md:
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 6: multprocessor
mult*i*
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 14: multi-processor
Should be spelled consistently with or without hyphen(?).
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 17: and
Remove?
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 17: With current and future CPU complexity and there might be some cases where : certain feature programming might be closed source in nature.
Sorry, please reword, as there is no correlation between CPU complexity and closed source.
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 22: close
closed
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 27: +
Add spaces around the +?
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 36: chrome
Google Chrome
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 40: to
Remove *to*.
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 41: non open source
closed source
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 43: cpu
CPU
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 46: operation.
Add blank line below?
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 47: ICL,etc
Please add a space after the comma.
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 48: option in order to perform SGX and C6DRAM enabling.
Please add a blank line below.
Done
https://review.coreboot.org/#/c/31841/4/Documentation/soc/intel/mp_init/mp_i... PS4, Line 49: platform
platforms
Done
-
Subrata Banik (Code Review)