Attention is currently required from: Lance Zhao, Patrick Georgi, Martin Roth, Tim Wawrzynczak, Julius Werner. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 )
Change subject: acpi,Makefile: Add preload_acpi_dsdt ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Well, what you have right now seems really fragile, if just shifting a few calls around here and the […]
I agree we can look into other solutions, but can we keep it simple for now?
I don't think the CBFS prefetch thread is the correct place for this to live though. It would have to be a new boot device that implements both RO and RW devices. This device can then keep a priority queue of `rdev` requests. It would then have to call out into the platform specific boot device to actually perform the work. The CBFS preload thread wouldn't need to change since it just uses `rdev_readat`.
On the AMD platform we have 2 boot devices:
RW: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
RO: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
We would need to devise a way to make the `delegator` boot device get handles to the `platform` boot devices. Right now the RO device implements `boot_device_ro`. We would need to implement some kind of new registration method that works with and without the `delegator` boot device.
There is still the outstanding question of having `_preload` methods for the files.
-
Raul Rangel (Code Review)