Attention is currently required from: Hung-Te Lin, Xi Chen, Martin Roth, Paul Menzel, Yu-Ping Wu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: Add mediatek mt8192 dram vendor code
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50294/comment/b39ba838_c210eed5
PS5, Line 11:
xixi's comments and the way he merged patches may lead to confusion. […]
That the code is developed/maintained somewhere else is a perfect argument
to put it into vendorcode/.
However, in case Mediatek maintains a public Git repository, we could also
integrated that as a submodule. I assume they don't do that?
Patchset:
PS5:
No, you have to make it clear "here's a drop from MTK's official release". […]
As this is not a clean move (it seems to add a newer version), I think two
patches would be cleaner. One that adds the current Mediatek-maintained
version. It can mention the version etc. and that this is maintained some-
where else, in the commit message. And a second that updates soc/ to use
the new vendorcode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4
Gerrit-Change-Number: 50294
Gerrit-PatchSet: 5
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
reinauer@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sun, 28 Feb 2021 14:49:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment