Change in ...coreboot[master]: [WIP]: add superio driver for sch5545 - coreboot-gerrit

4 Jun 2019


      Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20238 )
Change subject: [WIP]: add superio driver for sch5545
......................................................................
Patch Set 2:
...
Patch Set 2:
The header information seems outdated.
It doesnt build when configured into the Optiplex 790 because of unknown type names.
Update:
the include of <device/pnp_ops.h> is missing in either pnp.h or the sch5545_early_init.h, I dont know where it would be better to be added in.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/20238
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic258630b02e6ae86b1ee7ce663d9d026bf1c04e9
Gerrit-Change-Number: 20238
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Stuge peter@stuge.se
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Comment-Date: Tue, 04 Jun 2019 14:03:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment