Attention is currently required from: Kapil Porwal, Nick Vaccaro, Scott Chao.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79244?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79244/comment/aa1fd70a_26eb250e :
PS3, Line 11: AP(Application Processor)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/79244/comment/c3ef8b02_ebd2f2bd :
PS3, Line 11: cause
cause*s*
https://review.coreboot.org/c/coreboot/+/79244/comment/a0de593d_05c94f62 :
PS3, Line 11: triggered and it cause AP(Application Processor) to keep sending GET_NEXT_EVENT to EC during resume from suspend by connecting AC.
Please wrap the lines after 72 characters.
https://review.coreboot.org/c/coreboot/+/79244/comment/58337d12_7e3c9be0 :
PS3, Line 12: So we change GPP_F17 to edge triggered to avoid this condition.
Please add a blank line above to visually separate paragraphs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79244?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff
Gerrit-Change-Number: 79244
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 23 Nov 2023 12:09:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment