Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77990?usp=email )
Change subject: soc/amd/picasso: add eMMC MMIO device to devicetree
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
#hanetzer reported in #coreboot@irc.freenode. […]
i don't see how this patch would break things and i verified this on a picasso system to work. one thing to try might be to comment out the power_off_aoac_device call in emmc_enable in soc/amd/common/block/emmc/emmc.c and see how things behave in that case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5453b69df776d2ce1f3be11e37cd26c8c64f0cd5
Gerrit-Change-Number: 77990
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Marty E. Plummer
hanetzer@startmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 27 Sep 2023 17:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment