Franklin (Yanjin) He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39579 )
Change subject: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake ......................................................................
Patch Set 3:
(5 comments)
Marked off comments addressed in the latest patchset
https://review.coreboot.org/c/coreboot/+/39579/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39579/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/apollolake: enable GMM in devicetree for Gemini Lake
Almost what I was looking for, no need for the patch to be Private. […]
Done
https://review.coreboot.org/c/coreboot/+/39579/1//COMMIT_MSG@9 PS1, Line 9: Enables GMM if the pci device is enabled in the device tree for Gemini
s/device tree/devicetree/
Done
https://review.coreboot.org/c/coreboot/+/39579/1//COMMIT_MSG@10 PS1, Line 10: Lake
. […]
Done
https://review.coreboot.org/c/coreboot/+/39579/1//COMMIT_MSG@12 PS1, Line 12: A port of 03ddd190fd6a2e91b16e6fd8a101cf4e11d7cd7b
This ports `commit <hash>`. […]
Done
https://review.coreboot.org/c/coreboot/+/39579/1//COMMIT_MSG@16 PS1, Line 16:
This might be just a Gerrit display thing.
Done