Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Robert Chen, Nick Vaccaro, Shon Wang.
Name of user not set #1004174 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Change AMP driver setting
......................................................................
Patch Set 32: Code-Review-1
(3 comments)
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60331/comment/b77b88a1_139c8976
PS32, Line 173: device ref i2c0 on
these are all missing the entry to set them to external boost:
register "boost_type" = "1"
https://review.coreboot.org/c/coreboot/+/60331/comment/66cab903_c05032f3
PS32, Line 177: register "boost_peak_milliamp" = "4500"
: register "boost_ind_nanohenry" = "BOOST_IND_1000_NH"
: register "boost_cap_microfarad" = "24"
these aren't required for external boost.
same for below chips.
https://review.coreboot.org/c/coreboot/+/60331/comment/69c7b8de_fa825c47
PS32, Line 182: register "gpio_src_select[0]" = "GPIO_SRC_HIGH_IMPEDANCE"
the driver will override this anyway, so not critical, but gpio_src_select[0] should be GPIO_SRC_GPIO.
same for below chips.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 32
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Name of user not set #1004174
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 28 Feb 2022 11:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment