Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Update Kconfig
......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 102: if SOC_INTEL_TIGERLAKE
Code should have default value without condition ... […]
Ack
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 115: 16
This should be 12
Done
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 149: if SOC_INTEL_TIGERLAKE
Code should have default value without condition and this soc folder is TGL soc folder. […]
Ack
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 168: if SOC_INTEL_TIGERLAKE
Use default for Tigerlake which does not require condition.
Done
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 173: if SOC_INTEL_TIGERLAKE
Use default for Tigerlake which does not require condition.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c
Gerrit-Change-Number: 37426
Gerrit-PatchSet: 11
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 Jan 2020 01:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment