Change in coreboot[master]: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override

[Ravishankar Sarawadi (Code Review)]

Ravishankar Sarawadi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45085 )

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

[DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override

Signed-off-by: Ravi Sarawadi 
Change-Id: Ia052d7eb23e5f1c50ddb1ed05bb6c9897d6a21d6
---
M src/mainboard/google/volteer/variants/voxel/overridetree.cb
1 file changed, 16 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45085/1

diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb
index 43296d5..28e7e37 100644
--- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb
@@ -1,4 +1,10 @@
 chip soc/intel/tigerlake
+	# Disable SD Card PCIE 8 using clk 3
+	register "PcieRpEnable[7]" = "0"
+	register "PcieRpLtrEnable[7]" = "0"
+	register "PcieRpHotPlug[7]" = "0"
+	register "PcieClkSrcUsage[3]" = "0xFF"
+
    device domain 0 on
    	device pci 15.0 on
    		chip drivers/i2c/generic
@@ -142,5 +148,15 @@
    			end
    		end
    	end # PMC
+		device pci 1f.3 on
+			chip drivers/generic/max98357a
+				register "hid" = ""MX98357A""
+				register "sdmode_gpio" =  "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)"
+				register "sdmode_delay" = "5"
+				device generic 0 on
+				end
+			end
+		end # AUDIO
+
    end
 end

[Utkarsh H Patel (Code Review)]

Utkarsh H Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45085 )

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45085/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/voxel/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45085/1/src/mainboard/google/voltee... 
PS1, Line 23: chip drivers/i2c/max98373
            : 				register "vmon_slot_no" = "0"
            : 				register "imon_slot_no" = "1"
            : 				register "uid" = "0"
            : 				register "desc" = ""Right Speaker Amp""
            : 				register "name" = ""MAXR""
            : 				device i2c 31 on
            : 				end
            : 			end
            : 			chip drivers/i2c/max98373
            : 				register "vmon_slot_no" = "2"
            : 				register "imon_slot_no" = "3"
            : 				register "uid" = "1"
            : 				register "desc" = ""Left Speaker Amp""
            : 				register "name" = ""MAXL""
            : 				device i2c 32 on
            : 				end
            : 			end
You need to remove this.

[Ravishankar Sarawadi (Code Review)]

Hello Sathyanarayana Nujella, build bot (Jenkins), Utkarsh H Patel, Sukumar Ghorai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45085

to look at the new patch set (#2).

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

[DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override

Signed-off-by: Ravi Sarawadi 
Change-Id: Ia052d7eb23e5f1c50ddb1ed05bb6c9897d6a21d6
---
M src/mainboard/google/volteer/variants/voxel/overridetree.cb
1 file changed, 16 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45085/2

[Sukumar Ghorai (Code Review)]

Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45085 )

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

Patch Set 2: Code-Review+1

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45085 )

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

Patch Set 2:

Thank you Ravi,
LGTM for tests

[Ravishankar Sarawadi (Code Review)]

Hello Sathyanarayana Nujella, build bot (Jenkins), Utkarsh H Patel, Sukumar Ghorai, Sukumar Ghorai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45085

to look at the new patch set (#3).

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

[DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override

Signed-off-by: Ravi Sarawadi 
Change-Id: Ia052d7eb23e5f1c50ddb1ed05bb6c9897d6a21d6
---
M src/mainboard/google/volteer/variants/voxel/overridetree.cb
1 file changed, 16 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45085/3

[S] Change in coreboot[master]: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45085?usp=email )

Change subject: [DO-NOT-MERGE][TEST-ONLY] Audio and SD Card override
......................................................................

Abandoned