Change in coreboot[master]: mb/google/dedede: Add support for integrated BT enumeration

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Aamir Bohra (Code Review)

12 Mar 2020 12 Mar '20

9:12 a.m.

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

mb/google/dedede: Add support for integrated BT enumeration

The integrated BT is routed via USB2 port8, add USB configuration to support integrated BT enumeration.

Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 8 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39471/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 994e96e..4cd2400 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -31,10 +31,10 @@ register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" # Type-C Port C1 register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A1 - register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth + register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Not Used register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Not Used - register "usb2_ports[7]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Integrated Bluetooth

register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C0 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C1 @@ -188,11 +188,16 @@ device usb 2.3 on end end chip drivers/usb/acpi - register "desc" = ""Bluetooth"" + register "desc" = ""Discrete Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" device usb 2.4 on end end chip drivers/usb/acpi + register "desc" = ""Integrated Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.7 on end + end + chip drivers/usb/acpi register "desc" = ""Left Type-C Port"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(1, 1)"

Attachments:

attachment.htm (text/html — 4.8 KB)

Show replies by date

Furquan Shaikh (Code Review)

12 Mar 12 Mar

9:43 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 2:

This needs to be co-ordinated with: https://review.coreboot.org/c/coreboot/+/39446

Aamir Bohra (Code Review)

10:55 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 3:

...

Patch Set 2:

This needs to be co-ordinated with: https://review.coreboot.org/c/coreboot/+/39446

Ok, I also checked without above CL, the BT gets enumerated under lsusb. The BT_DISABLE I think is for radio disable.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Thu, 12 Mar 2020 17:55:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:01 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 3:

...

Patch Set 3:

...
Patch Set 2:

This needs to be co-ordinated with: https://review.coreboot.org/c/coreboot/+/39446

Ok, I also checked without above CL, the BT gets enumerated under lsusb. The BT_DISABLE I think is for radio disable.

I just meant that the disable gpio support will have to be added to the CNVi BT port as well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Thu, 12 Mar 2020 18:01:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aamir Bohra (Code Review)

11:12 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 3:

...

Patch Set 3:

...
Patch Set 3:

...
Patch Set 2:

This needs to be co-ordinated with: https://review.coreboot.org/c/coreboot/+/39446

Ok, I also checked without above CL, the BT gets enumerated under lsusb. The BT_DISABLE I think is for radio disable.

I just meant that the disable gpio support will have to be added to the CNVi BT port as well.

Ok, Understood :-)

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Thu, 12 Mar 2020 18:12:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

13 Mar 13 Mar

6:36 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 4:

...

Patch Set 3:

...
Patch Set 3:

...
Patch Set 3:

...
Patch Set 2:

This needs to be co-ordinated with: https://review.coreboot.org/c/coreboot/+/39446

Ok, I also checked without above CL, the BT gets enumerated under lsusb. The BT_DISABLE I think is for radio disable.

I just meant that the disable gpio support will have to be added to the CNVi BT port as well.

Ok, Understood :-)

Does Integrated Bluetooth use the same GPIO as Discrete GPIO for enable/disable?

EDS does not seem to capture Integrated BT using USB2 Port 7 information. I just want to confirm that Integrated BT is not using a hidden USB port like in GLK.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 4 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Fri, 13 Mar 2020 13:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aamir Bohra (Code Review)

15 Mar 15 Mar

11:27 p.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 4:

...

Patch Set 4:

...
Patch Set 3:

...
Patch Set 3:

...
Patch Set 3:

...
Patch Set 2:

This needs to be co-ordinated with: https://review.coreboot.org/c/coreboot/+/39446

Ok, I also checked without above CL, the BT gets enumerated under lsusb. The BT_DISABLE I think is for radio disable.

I just meant that the disable gpio support will have to be added to the CNVi BT port as well.

Ok, Understood :-)

Does Integrated Bluetooth use the same GPIO as Discrete GPIO for enable/disable?

EDS does not seem to capture Integrated BT using USB2 Port 7 information. I just want to confirm that Integrated BT is not using a hidden USB port like in GLK.

Does Integrated Bluetooth use the same GPIO as Discrete GPIO for enable/disable? Yes.

...

EDS does not seem to capture Integrated BT using USB2 Port 7 information. I just want to confirm that Integrated BT is not using a hidden USB port like in GLK.

Schematics had a note on this, if Integrated BT is not used, it can be used as normal USB port.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 4 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Mon, 16 Mar 2020 06:27:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

16 Mar 16 Mar

12:41 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Add support for integrated BT enumeration ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39471/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39471/4//COMMIT_MSG@7 PS4, Line 7: mb/google/dedede: Add support for integrated BT enumeration Support integratred BT enumeration

https://review.coreboot.org/c/coreboot/+/39471/4//COMMIT_MSG@9 PS4, Line 9: port8 port 8

https://review.coreboot.org/c/coreboot/+/39471/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/39471/4/src/mainboard/google/dedede... PS4, Line 34: register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth What is *discrete* Bluetooth?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 4 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Mar 2020 07:41:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aamir Bohra (Code Review)

7:17 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Hello build bot (Jenkins), Tim Wawrzynczak, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39471

to look at the new patch set (#5).

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

mb/google/dedede: Support integratred BT enumeration

The integrated BT is routed via USB2 port 8, add USB configuration to support integrated BT enumeration.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39471/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Aamir Bohra (Code Review)

7:19 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39471/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39471/4//COMMIT_MSG@7 PS4, Line 7: mb/google/dedede: Add support for integrated BT enumeration

...

Support integratred BT enumeration

Done

https://review.coreboot.org/c/coreboot/+/39471/4//COMMIT_MSG@9 PS4, Line 9: port8

...

port 8

Done

https://review.coreboot.org/c/coreboot/+/39471/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/39471/4/src/mainboard/google/dedede... PS4, Line 34: register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth

...

What is *discrete* Bluetooth?

Bluetooth that does not rely on digital processing from SOC.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Mar 2020 02:19:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Aamir Bohra (Code Review)

7:20 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39471/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/39471/4/src/mainboard/google/dedede... PS4, Line 34: register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth

...

Bluetooth that does not rely on digital processing from SOC.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Mar 2020 02:20:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

10:32 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39471/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/39471/5/src/mainboard/google/dedede... PS5, Line 197: register "type" = "UPC_TYPE_INTERNAL" Please rebase and add the BT_DISABLE GPIO config here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Mar 2020 05:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aamir Bohra (Code Review)

11:05 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Hello build bot (Jenkins), Tim Wawrzynczak, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39471

to look at the new patch set (#7).

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

mb/google/dedede: Support integratred BT enumeration

The integrated BT is routed via USB2 port 8, add USB configuration to support integrated BT enumeration.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39471/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 7 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Aamir Bohra (Code Review)

11:05 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39471/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/39471/5/src/mainboard/google/dedede... PS5, Line 197: register "type" = "UPC_TYPE_INTERNAL"

...

Please rebase and add the BT_DISABLE GPIO config here.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 7 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Mar 2020 06:05:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

17 Mar 17 Mar

4:05 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 7 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Mar 2020 23:05:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

18 Mar 18 Mar

9:46 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Support integratred BT enumeration

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39471 )

Change subject: mb/google/dedede: Support integratred BT enumeration ......................................................................

mb/google/dedede: Support integratred BT enumeration

The integrated BT is routed via USB2 port 8, add USB configuration to support integrated BT enumeration.

Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39471 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 9 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 9a8ad66..ece9672a 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -31,10 +31,10 @@ register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" # Type-C Port C1 register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A1 - register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth + register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Not Used register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Not Used - register "usb2_ports[7]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Integrated Bluetooth

register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C0 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C1 @@ -190,12 +190,18 @@ device usb 2.3 on end end chip drivers/usb/acpi - register "desc" = ""Bluetooth"" + register "desc" = ""Discrete Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" device usb 2.4 on end end chip drivers/usb/acpi + register "desc" = ""Integrated Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" + device usb 2.7 on end + end + chip drivers/usb/acpi register "desc" = ""Left Type-C Port"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(1, 1)"

-- To view, visit https://review.coreboot.org/c/coreboot/+/39471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d8c92ba57cd72a91ee15ef4d11f07824c29e9a Gerrit-Change-Number: 39471 Gerrit-PatchSet: 8 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1828

days inactive

1834

days old

coreboot-gerrit@coreboot.org

15 comments

5 participants

tags (0)

participants (5)

Aamir Bohra (Code Review)
Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)