Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80699?usp=email )
Change subject: soc/amd/glinda: Use gpp_clk_setup_common function
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/glinda/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/80699/comment/674ab615_cb5e80a5 :
PS1, Line 90: #define GPP_CLK_OUTPUT_AVAILABLE 4
this likely needs to be updated to match the silicon, but that's something for a separate patch, sin […]
sure,
will push a patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80699?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0c1cda0d36de48c7f7315a1b8203b0e53f63f75
Gerrit-Change-Number: 80699
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Feb 2024 14:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment