Attention is currently required from: Nico Huber, Martin Roth, Tim Wawrzynczak, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52520 )
Change subject: soc/intel/broadwell/pch: Replace ACPI device NVS
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/broadwell/pch/acpi.c:
https://review.coreboot.org/c/coreboot/+/52520/comment/9b925b00_8a08e5cd
PS2, Line 23: const struct opregion opreg = {
: .name = "SPRT",
: .regionspace = SYSTEMMEMORY,
: .regionoffset = bar1 + 0x84,
: .regionlen = spcs.bits / 8,
: };
You don't like the macros? 😋 […]
I'm not a fan of macros, but I can switch to using them if it's customary in acpigen.
File src/soc/intel/broadwell/pch/serialio.c:
https://review.coreboot.org/c/coreboot/+/52520/comment/446ad9ea_0eab460b
PS1, Line 19: #include <version.h>
unrelated?
Gone. I originally wanted to add the acpigen code in serialio.c, but decided against it later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52520
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89fb658fbb10a8769ebea2e6535c45cd7c212d06
Gerrit-Change-Number: 52520
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 21 Apr 2021 22:18:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment