Attention is currently required from: Arthur Heymans, Felix Singer, Jérémy Compostella, Lean Sheng Tan, Subrata Banik.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75552?usp=email )
Change subject: include/cpu/x86: Simplify en/dis cache functions
......................................................................
Patch Set 3:
(1 comment)
File src/include/cpu/x86/cache.h:
https://review.coreboot.org/c/coreboot/+/75552/comment/d7518f89_9b504718 :
PS2, Line 48: CR0_CacheDisable
want me to change it to screaming snake case -> CR0_CACHE_DISABLE?
yup, this is what make sense.
Also, these macros being in use already, better to do it in different CL to change everywhere.
sure
CR0_CD and CR0_NW is fine too IMO
+1
Done. May be we should drop the usage instead of changing the case of these macros throughout.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81688e8bbb073e1d09ecf63f3f33e1651dbd778e
Gerrit-Change-Number: 75552
Gerrit-PatchSet: 3
Gerrit-Owner: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 14:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Himanshu Sahdev
himanshu.sahdev@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment