Change in coreboot[master]: device/azalia_device.c: Replace comment with proper code

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48352 )

Change subject: device/azalia_device.c: Replace comment with proper code
......................................................................

device/azalia_device.c: Replace comment with proper code

Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5
Signed-off-by: Angel Pons 
---
M src/device/azalia_device.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48352/1

diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c
index e46c27f..b18d938 100644
--- a/src/device/azalia_device.c
+++ b/src/device/azalia_device.c
@@ -115,7 +115,7 @@
    int idx = 0;

while (idx < (verb_table_bytes / sizeof(u32))) {
-		u32 verb_size = 4 * verb_table[idx + 2];	// in u32
+		u32 verb_size = verb_table[idx + 2] * sizeof(u32);
    	if (verb_table[idx] != viddid) {
    		idx += verb_size + 3;	// skip verb + header
    		continue;

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48352 )

Change subject: device/azalia_device.c: Replace comment with proper code
......................................................................

Patch Set 4: Code-Review+2

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48352 )

Change subject: device/azalia_device.c: Replace comment with proper code
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: device/azalia_device.c: Clarify comment

[Angel Pons (Code Review)]

Hello  Felix Singer, build bot (Jenkins), Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48352

to look at the new patch set (#5).

Change subject: device/azalia_device.c: Clarify comment
......................................................................

device/azalia_device.c: Clarify comment

The `4` here doesn't have to do with the size of u32. Instead, it is
because the verb header contains the number of jacks, which is the
number of four-verb groups.

Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5
Signed-off-by: Angel Pons 
---
M src/device/azalia_device.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48352/5

Change in coreboot[master]: device/azalia_device.c: Clarify comment

[Angel Pons (Code Review)]

Hello  Felix Singer, build bot (Jenkins), Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48352

to look at the new patch set (#6).

Change subject: device/azalia_device.c: Clarify comment
......................................................................

device/azalia_device.c: Clarify comment

The `4` here doesn't have to do with the size of u32. Instead, it is
because the verb header contains the number of jacks, which is the
number of four-verb groups.

Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5
Signed-off-by: Angel Pons 
---
M src/device/azalia_device.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48352/6

Change in coreboot[master]: device/azalia_device.c: Clarify comment

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48352 )

Change subject: device/azalia_device.c: Clarify comment
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: device/azalia_device.c: Clarify comment

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48352 )

Change subject: device/azalia_device.c: Clarify comment
......................................................................

device/azalia_device.c: Clarify comment

The `4` here doesn't have to do with the size of u32. Instead, it is
because the verb header contains the number of jacks, which is the
number of four-verb groups.

Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48352
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/device/azalia_device.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c
index e46c27f..ab370f9 100644
--- a/src/device/azalia_device.c
+++ b/src/device/azalia_device.c
@@ -115,7 +115,8 @@
    int idx = 0;

while (idx < (verb_table_bytes / sizeof(u32))) {
-		u32 verb_size = 4 * verb_table[idx + 2];	// in u32
+		/* Header contains the number of jacks, aka groups of 4 dwords */
+		u32 verb_size = 4 * verb_table[idx + 2];
    	if (verb_table[idx] != viddid) {
    		idx += verb_size + 3;	// skip verb + header
    		continue;