Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78818?usp=email )
Change subject: soc/amd/common/psp: Remove unnecessary prompts from Kconfig ......................................................................
soc/amd/common/psp: Remove unnecessary prompts from Kconfig
I think this was probably a cut & paste error. We don't want prompts for the "default" Kconfig options. Those should be set by the platform, not the end user. These prompts didn't make sense where they were in the Kconfig menus either.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: Idcd2ba84591d31a9a25bcc6cae3ec163939d7836 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78818 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com Reviewed-by: Eric Lai ericllai@google.com --- M src/soc/amd/common/block/psp/Kconfig 1 file changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Eric Lai: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/block/psp/Kconfig b/src/soc/amd/common/block/psp/Kconfig index d86ad7c..47e3fc4 100644 --- a/src/soc/amd/common/block/psp/Kconfig +++ b/src/soc/amd/common/block/psp/Kconfig @@ -94,25 +94,25 @@ Select this config to indicate SoC includes Hardware Security Processor(HSP).
config AMD_FWM_POSITION_20000_DEFAULT - bool "0x20000" + bool
config AMD_FWM_POSITION_420000_DEFAULT - bool "0x420000" + bool
config AMD_FWM_POSITION_820000_DEFAULT - bool "0x820000" + bool
config AMD_FWM_POSITION_C20000_DEFAULT - bool "0xC20000" + bool
config AMD_FWM_POSITION_E20000_DEFAULT - bool "0xE20000" + bool
config AMD_FWM_POSITION_F20000_DEFAULT - bool "0xF20000" + bool
config AMD_FWM_POSITION_FA0000_DEFAULT - bool "0xFA0000" + bool
choice AMD_FWM_POSITION_CHOICE prompt "AMD FW position"