Change in ...coreboot[master]: intel/fsp1_1: Drop unused, weak raminit()

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32587

Change subject: intel/fsp1_1: Drop unused, weak raminit()
......................................................................

intel/fsp1_1: Drop unused, weak raminit()

Change-Id: I5d155df1d589fc8d7462f46e87275bd6efae0a7f
Signed-off-by: Nico Huber 
---
M src/drivers/intel/fsp1_1/romstage.c
1 file changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32587/1

diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c
index ebb6a66..bfed121 100644
--- a/src/drivers/intel/fsp1_1/romstage.c
+++ b/src/drivers/intel/fsp1_1/romstage.c
@@ -343,13 +343,6 @@
    return -1;
 }

-/* Transition RAM from off or self-refresh to active */
-__weak void raminit(struct romstage_params *params)
-{
-	post_code(POST_MEM_PREINIT_PREP_START);
-	die("ERROR - No RAM initialization specified!\n");
-}
-
 /* Display the memory configuration */
 __weak void report_memory_config(void)
 {

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32587 )

Change subject: intel/fsp1_1: Drop unused, weak raminit()
......................................................................

Patch Set 1: Code-Review+1

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32587 )

Change subject: intel/fsp1_1: Drop unused, weak raminit()
......................................................................

Patch Set 1: Code-Review+2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32587 )

Change subject: intel/fsp1_1: Drop unused, weak raminit()
......................................................................

Patch Set 1: Code-Review+1

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32587 )

Change subject: intel/fsp1_1: Drop unused, weak raminit()
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32587 )

Change subject: intel/fsp1_1: Drop unused, weak raminit()
......................................................................

intel/fsp1_1: Drop unused, weak raminit()

Change-Id: I5d155df1d589fc8d7462f46e87275bd6efae0a7f
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32587
Tested-by: build bot (Jenkins) 
Reviewed-by: Matt DeVillier 
Reviewed-by: Patrick Rudolph 
Reviewed-by: Frans Hendriks 
Reviewed-by: Michał Żygowski 
---
M src/drivers/intel/fsp1_1/romstage.c
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, but someone else must approve
  Patrick Rudolph: Looks good to me, approved
  Frans Hendriks: Looks good to me, but someone else must approve
  Michał Żygowski: Looks good to me, approved

diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c
index ebb6a66..bfed121 100644
--- a/src/drivers/intel/fsp1_1/romstage.c
+++ b/src/drivers/intel/fsp1_1/romstage.c
@@ -343,13 +343,6 @@
    return -1;
 }

-/* Transition RAM from off or self-refresh to active */
-__weak void raminit(struct romstage_params *params)
-{
-	post_code(POST_MEM_PREINIT_PREP_START);
-	die("ERROR - No RAM initialization specified!\n");
-}
-
 /* Display the memory configuration */
 __weak void report_memory_config(void)
 {